Add Jackson 3 plugin and migrate publishing to maven-publish#185
Add Jackson 3 plugin and migrate publishing to maven-publish#185Sboti03 wants to merge 7 commits intoorigin-energy:masterfrom
Conversation
| mavenCentral() | ||
| } | ||
|
|
||
| if (subproject.name == 'java-snapshot-testing-plugin-jackson3') { |
There was a problem hiding this comment.
Why is this long if else needed as it wasn't required previously? Will the code work without it?
There was a problem hiding this comment.
The Jackson 3 module needs Java 17 because Jackson 3 artifacts require Java 17.
The long root if/else is not needed the default can stay Java 11 and Jackson 3 can override locally.
| afterEvaluate { | ||
| if (project.hasProperty("sign")) { | ||
| signing { | ||
| sign publishing.publications |
There was a problem hiding this comment.
Why did this get separated from the project.hasProperty("sign") step?
There was a problem hiding this comment.
Because publishing metadata is required for every Maven publication.
Signing is optional and should only control signature generation.
|
@jackmatt2 I've made the fixes you requested and fixed the pipelines. |
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| java_version: [ '8' ] |
There was a problem hiding this comment.
Can the versions remain here so they don't need to be duplicated
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| java_version: [ '8' ] |
There was a problem hiding this comment.
I think we need to continue to support java 8 - otherwise we break these clients
2 participants
What changed
Build and publishing
Jackson 3 support
Validation
Ran:
./gradlew publishToMavenLocal
./gradlew :java-snapshot-testing-plugin-jackson3:test publishToMavenLocal
Notes
fixes #183